smoke_render: run the goldens on PRs#147
Merged
Merged
Conversation
Add pull_request and push-to-master triggers plus a concurrency guard, so Argos compares each PR's frames against the master baseline instead of only refreshing the baseline on a schedule. Gate the Discord failure ping to non-PR runs, since a PR failure surfaces as the PR check. Turning the Argos diff into a merge gate still needs the Argos GitHub App installed and its check marked required in branch protection.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triggers the smoke-render canary on
pull_requestandpushto master (with a concurrency guard) so Argos diffs each PR's rendered frames against the master baseline, instead of only refreshing the baseline on the daily schedule. The Discord failure ping is gated to non-PR runs, since a PR failure surfaces as the PR check.This is the CI half of gating PRs on the goldens. Two manual steps complete it: install the Argos GitHub App on the repo so it posts the per-PR status check, and mark that check required for
masterin branch protection.